Differential D10540

[Kickoff] Move RunnerModel to SearchView
ClosedPublic
Actions

Authored by broulik on Feb 15 2018, 1:32 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R119:30530ab36020: [Kickoff] Move RunnerModel to SearchView
Summary

It's only used there.

Test Plan

Verified that SearchView is created only once (conditional loader) and not re-created every time a query is fired
Searching still works
Invoking a result, jump list actions, and pinning a result to panel still worked

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 15 2018, 1:32 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 15 2018, 1:32 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 15 2018, 1:32 PM
davidedmundson accepted this revision.Feb 15 2018, 1:36 PM
This revision is now accepted and ready to land.Feb 15 2018, 1:36 PM
Closed by commit R119:30530ab36020: [Kickoff] Move RunnerModel to SearchView (authored by broulik). · Explain WhyFeb 15 2018, 1:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27250

View Options

applets/kickoff/package/contents/ui/FullRepresentation.qml

Loading...
View Options

applets/kickoff/package/contents/ui/SearchView.qml

Loading...