Kill QmlObjectIncubationController
ClosedPublic

Authored by broulik on Feb 15 2018, 11:24 AM.

Details

Summary

All it does is slow things down artificially for no real gain. It's not like it does anything smart, like "preload" or "incubate" when the system is idle.

Test Plan

A more radical approach than D10531 - similar results performance-wise

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 15 2018, 11:24 AM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptFeb 15 2018, 11:24 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 15 2018, 11:24 AM

This made my system ironically more responsive than it was before, even with the QML cache cleared.
I guess a lot changed in Qt since it was written.

I can't think of a situation where I'd want to process anything other than the thing I'm waiting on. Especially as I've seen code which tries to be smart and do a delayed load, which with this potentially end up being done first with this.

+1 from me

mart added a subscriber: mart.Feb 15 2018, 11:43 AM

I can't think of a situation where I'd want to process anything other than the thing I'm waiting on.

uuh, user input?

mart added a comment.Feb 15 2018, 11:47 AM

anyways, i'll try it together with the preload stuff and see if there is some noticeable difference, for better of for worse

mart accepted this revision.Feb 15 2018, 11:51 AM

doesn't seem to harm the interactivity of the system while loading popups in the background, so ship it :)

This revision is now accepted and ready to land.Feb 15 2018, 11:51 AM
This revision was automatically updated to reflect the committed changes.