Improve "show more reviews" string and logic
ClosedPublic

Authored by ngraham on Feb 15 2018, 5:22 AM.

Details

Summary

Use slightly more natural text for the "show more reviews" button.

Also fix the bug where the "show more reviews" text would be absent if rating was null, which triggered logic that set the number of reviews to be 0. This didn't seem to be adding anything, so I removed it and everything still seems to work fine.

Test Plan

Browsed a ton of apps. All appeared as expected, including apps like OpenScad that were previously affected by the above bug.

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Feb 15 2018, 5:22 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 15 2018, 5:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 15 2018, 5:22 AM
ngraham edited the test plan for this revision. (Show Details)Feb 15 2018, 5:23 AM
apol accepted this revision.Feb 15 2018, 12:17 PM
This revision is now accepted and ready to land.Feb 15 2018, 12:17 PM
This revision was automatically updated to reflect the committed changes.