Improve ToolBarApplicationHeader left padding and eliding behavior
ClosedPublic

Authored by ngraham on Feb 15 2018, 4:02 AM.

Details

Summary

If the header text is going to be left aligned, we'd better give it some left padding so it looks all right. Also fix eliding, which did not work at all before because no width value was set.

Supports T7958: Adopt Kirigami ToolBarApplicationHeader

Test Plan

No regressions seen in Kirigami Gallery.

Discover Featured page, before:

Discover Featured page, after:

Discover Flathub page, before:

Discover Flathub page, after:

Diff Detail

Repository
R169 Kirigami
Branch
header-polish (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Feb 15 2018, 4:02 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptFeb 15 2018, 4:02 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 15 2018, 4:02 AM
ngraham edited the test plan for this revision. (Show Details)Feb 15 2018, 4:07 AM
ngraham edited the summary of this revision. (Show Details)Feb 15 2018, 5:59 AM
mart accepted this revision.Feb 15 2018, 9:59 AM
This revision is now accepted and ready to land.Feb 15 2018, 9:59 AM
ngraham closed this revision.Feb 15 2018, 2:51 PM