Fix launching by touchscreen tap
ClosedPublic

Authored by hein on Feb 14 2018, 3:51 PM.

Details

Summary

The mouse handling code relied on onPositionChanged to do setup work
prior to onPressed. This is never guaranteed, but it's is likely to
happen when using the mouse (since the pointer is usually moved from
a panel icon to a delegate elsewhere on screen). In a touchscreen
scenario, these odds reverse.

The lesson to take away: Never assume onPositionChanged has run
before onPressed.

BUG:366527

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.Feb 14 2018, 3:51 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 14 2018, 3:51 PM
hein requested review of this revision.Feb 14 2018, 3:51 PM
mart accepted this revision.Feb 14 2018, 3:53 PM
This revision is now accepted and ready to land.Feb 14 2018, 3:53 PM
This revision was automatically updated to reflect the committed changes.