Differential D10508

Add icons for KStandardActions Deselect and Replace
ClosedPublic
Actions

Authored by mmustac on Feb 14 2018, 2:43 PM.

Details

Reviewers
ngraham
Group Reviewers
Frameworks
Commits
R265:5bd125e26d0b: Add icons for KStandardActions Deselect and Replace
Summary

I added also here the icons for the "replace" and "deselect" action.

Diff Detail

Repository
R265 KConfigWidgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mmustac created this revision.Feb 14 2018, 2:43 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 14 2018, 2:43 PM
mmustac requested review of this revision.Feb 14 2018, 2:43 PM
ngraham accepted this revision.Feb 14 2018, 2:58 PM

Works great! Do you know how to deploy this patch such that apps e.g. Kate can pick up the change?

This revision is now accepted and ready to land.Feb 14 2018, 2:58 PM
ngraham added a comment.Feb 14 2018, 2:59 PM

Also, you don't need "[KStandardAction]" in the title. A better commit message would indicate the actual icons. Maybe something like this:

"Add icons for KStandardActions Deselect and Replace"

See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

mmustac retitled this revision from [KStandardAction] Add additional icons to menus to Add icons for KStandardActions Deselect and Replace.Feb 14 2018, 3:01 PM

I can't access the link at the moment but changed the title according ;)
And kate picks up this change automatically because they relay on this framework already or did I get you wrong?

ngraham added a comment.Feb 14 2018, 3:03 PM

Yep, I just wanted to make sure you knew how to deploy it properly to test.

Closed by commit R265:5bd125e26d0b: Add icons for KStandardActions Deselect and Replace (authored by mmustac, committed by ngraham). · Explain WhyFeb 14 2018, 3:04 PM
This revision was automatically updated to reflect the committed changes.
mmustac edited the summary of this revision. (Show Details)Feb 14 2018, 3:11 PM
ngraham added a comment.Feb 14 2018, 3:19 PM

Thanks for the image; now I can feature it in this coming weekend's Usability & Productivity post!

Revision Contents
Changeset List

PathPackages
Msrc/kstandardaction_p.h (4 lines)

Diff 27156

View Options

src/kstandardaction_p.h

Loading...