Turn code.js into a singleton
ClosedPublic
Actions

Authored by broulik on Feb 14 2018, 2:41 PM.

Details

Reviewers

hein
davidedmundson

Group Reviewers

Plasma

Commits

R119:0d6792c4a7fc: Turn code.js into a singleton

Summary

Otherwise we would create an instance of this JS file for every delegate.
The only contextual object it uses is i18n, so pass that in for the function call.

Test Plan

Verified that the JS file is created only once. Speeds up things somewhat.
Verified that the favorites action still shows properly and works

Diff Detail

Repository

R119 Plasma Desktop

Lint

Lint Skipped

Unit

Unit Tests Skipped

broulik created this revision.Feb 14 2018, 2:41 PM

Restricted Application added a project: Plasma. · View Herald TranscriptFeb 14 2018, 2:41 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Feb 14 2018, 2:41 PM

davidedmundson accepted this revision.Feb 15 2018, 12:45 AM

This revision is now accepted and ready to land.Feb 15 2018, 12:45 AM

Nice! Thanks.

Closed by commit R119:0d6792c4a7fc: Turn code.js into a singleton (authored by broulik). · Explain WhyFeb 15 2018, 12:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			applets/kicker/package/contents/code/tools.js (8 lines)
M			applets/kicker/package/contents/ui/DashboardRepresentation.qml (2 lines)
M			applets/kicker/package/contents/ui/ItemGridDelegate.qml (2 lines)
M			applets/kicker/package/contents/ui/ItemListDelegate.qml (2 lines)
M			applets/kicker/package/contents/ui/SideBarItem.qml (2 lines)
M			applets/kickoff/package/contents/code/tools.js (8 lines)
M			applets/kickoff/package/contents/ui/KickoffItem.qml (2 lines)