Differential D10503

Add icons to Edit menu
ClosedPublic
Actions

Authored by mmustac on Feb 14 2018, 9:08 AM.

Details

Reviewers
ngraham
Group Reviewers
Dolphin
Commits
R318:9a7569a82a29: Add icons to Edit menu
Summary

Since Breeze offers such a great palette of action icons I thought we should make use of them which make things also more consistent with other applications.

Before:

After:

Test Plan

Show menubar
Icons are shown in Edit menu

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mmustac requested review of this revision.Feb 14 2018, 9:08 AM
mmustac created this revision.
ngraham accepted this revision.Feb 14 2018, 2:13 PM
ngraham added a subscriber: ngraham.

Looks great to me! Let's use those icons.

This revision is now accepted and ready to land.Feb 14 2018, 2:13 PM
ngraham added a comment.Feb 14 2018, 2:14 PM

Do you have commit access? If not, and you need me to commit for you, what's your email address?

mmustac added a comment.Feb 14 2018, 2:39 PM

No I don't have commit access so far.
My email is mustacmarijo@googlemail.com

Closed by commit R318:9a7569a82a29: Add icons to Edit menu (authored by mmustac, committed by ngraham). · Explain WhyFeb 14 2018, 2:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/dolphinmainwindow.cpp (2 lines)

Diff 27153

View Options

src/dolphinmainwindow.cpp

Loading...