Differential D10502

Eliminate unnecessary bottom padding on OverlaySheets
ClosedPublic
Actions

Authored by ngraham on Feb 14 2018, 3:40 AM.

Details

Reviewers
apol
mart
Group Reviewers
Kirigami
Commits
R169:cf677c81c7ff: Eliminate unnecessary bottom padding on OverlaySheets
Summary

The OverlaySheet already incorporates topMargin and bottomMargin into its height calculation, so we don't need to add any extra padding.

BUG: 390032

Test Plan

Tested with Discover's review input sheet.

Before:

After:

Also tested in Kirigami Gallery; all pop-ups I could find still looked good.

Diff Detail

Repository
R169 Kirigami
Branch
less-popup-padding
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Feb 14 2018, 3:40 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptFeb 14 2018, 3:40 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 14 2018, 3:40 AM
ngraham edited the test plan for this revision. (Show Details)Feb 14 2018, 3:41 AM
apol added inline comments.Feb 14 2018, 1:01 PM
src/controls/templates/OverlaySheet.qml
270 ↗(On Diff #27133)

Does this mean that setting the topPadding and bottomPadding to 0 would make this empty space go away?

ngraham updated this revision to Diff 27150.EditedFeb 14 2018, 2:05 PM

Use a more programmatically correct approach (topPadding+bottomPadding instead of Units.gridUnit*2); this will work for clients that change the padding values

ngraham marked an inline comment as done.Feb 14 2018, 2:06 PM
ngraham edited the summary of this revision. (Show Details)
apol added a comment.Feb 14 2018, 3:24 PM

+1 makes sense to me.

ngraham retitled this revision from Eliminate unnecessary bottom pading on OverlaySheets to Eliminate unnecessary bottom padding on OverlaySheets.Feb 14 2018, 3:34 PM
mart accepted this revision.Feb 14 2018, 3:53 PM
This revision is now accepted and ready to land.Feb 14 2018, 3:53 PM
ngraham closed this revision.Feb 14 2018, 4:45 PM

Revision Contents
Changeset List

Diff 27150

View Options

src/controls/templates/OverlaySheet.qml

Loading...