Before all suggestions are only shown as single item with a text of
comma-separated terms. So one cannot select a single suggested term and e.g.
copy it to the clipboard
And if correct term, the term is not copyable directly as well.
Details
Details
Activate spellcheck runner (disabled by default), enter
"spell Compilcated" or similar
and select spellchecker menu items.
Diff Detail
Diff Detail
- Repository
- R114 Plasma Addons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| runners/spellchecker/spellcheck.cpp | ||
|---|---|---|
| 232 | Not sure if HelperMatch is the correct thing here. Similar runners use InformationalMatch here, so on selection the term is copied into the runner. What is the modern krunner way to support the use-case of someone wanting to know the spelling of some word, and then copy the correct or suggested into the clipboard for further usage? | |
Comment Actions
and then copy the correct or suggested into the clipboard for further usage?
Calculator runner does setText on QClipboard in run, so I guess this is the way.
InformationalMatch causes the data to be set as query when run. Pick your poison.
| runners/spellchecker/spellcheck.cpp | ||
|---|---|---|
| 235 | Add some context, "Correct" could also be a verb | |
Comment Actions
Thanks for review.
Which seems to not be triggered when chosing the match though, from what I tested incl. extra debug log.
Currently one has to use the action enabled on the match to get the result copied to the clipboard.
So chance is that code is dead code, either due to being copy&paste on plugin creation or due to policy changes in krunner plasma5 porting?
InformationalMatch causes the data to be set as query when run. Pick your poison.
I guess that most use cases with this runner are when someone wants to use to correct term in other places, so on selecting the match people do not intend to have it as new query content for further queries, but have the term straight available for use in that other place (-> clipboard).
So considering to take the HelperMatch pill. Though might also go for extra copy action as with calculator.