Added missing image format
ClosedPublic

Authored by anemeth on Feb 14 2018, 12:02 AM.

Details

Summary

QImage::Format_ARGB6666_Premultiplied was missing from the image format table.
This might have caused some bugs later on.
See: http://doc.qt.io/qt-5/qimage.html#Format-enum

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
anemeth created this revision.Feb 14 2018, 12:02 AM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 14 2018, 12:02 AM
Restricted Application added subscribers: KWin, kwin. · View Herald Transcript
anemeth requested review of this revision.Feb 14 2018, 12:02 AM
anemeth edited the summary of this revision. (Show Details)Feb 14 2018, 12:03 AM
anemeth added reviewers: fredrik, KWin.
anemeth edited the summary of this revision. (Show Details)
cfeck added a subscriber: cfeck.Feb 14 2018, 12:10 AM
cfeck added inline comments.
libkwineffects/kwingltexture.cpp
116

So is it ARGB6666 or RGB666 ?

anemeth updated this revision to Diff 27124.Feb 14 2018, 12:12 AM

Fixed typo in the comment

libkwineffects/kwingltexture.cpp
116

Whoops, my mistake.
It's ARGB6666
Fixed

anemeth marked 2 inline comments as done.Feb 14 2018, 12:13 AM
fredrik accepted this revision.Feb 14 2018, 10:22 PM

Nice find!

This revision is now accepted and ready to land.Feb 14 2018, 10:22 PM
This revision was automatically updated to reflect the committed changes.