Workaround to restore KF5 programs from system tray
AbandonedPublic

Authored by stikonas on Feb 13 2018, 9:18 PM.

Details

Reviewers
wbauer
davidedmundson
volkov
Group Reviewers
Plasma
Summary

Currently restoring system tray does not work on Wayland.

Even with this commit, the functionality is still worse than on X11 because clicking on system tray does not hide application window.

Diff Detail

Repository
R289 KNotifications
Lint
Lint Skipped
Unit
Unit Tests Skipped
stikonas created this revision.Feb 13 2018, 9:18 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptFeb 13 2018, 9:18 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
stikonas requested review of this revision.Feb 13 2018, 9:18 PM

This is more to start some discussion on system tray under Wayland. I'm not sure myself if this should be committed. I just use this workaround locally until winId() works on Wayland.

wbauer added a subscriber: KWin.Feb 13 2018, 11:04 PM

Indeed.
One thing that started this is https://bugs.kde.org/show_bug.cgi?id=389663

I do think this should be fixed on the lower level if possible.

Adding KWin as subscriber as well to hopefully get most people that have more insight.

This is more to start some discussion on system tray under Wayland. I'm not sure myself if this should be committed. I just use this workaround locally until winId() works on Wayland.

winId will never work. I cannot say much on the patch as the context is missing.

Well, basically when you click on any KF5 application (e.g. Konversation, KGpg, Akregator, etc...) in the system tray, nothing happens.
This does no happen with Qt5-only programs. Clicking on system tray there always brings the window up.

From what I can see in the code, on X11 KWindowSystem::activateWindow(associatedWidget->winId()); raises the window
but if I understand correctly KWindowSystem::activateWindow can never work on Wayland. This is clearly not what end user
would expect.

stikonas updated this revision to Diff 27181.Feb 14 2018, 8:21 PM
stikonas abandoned this revision.Feb 14 2018, 8:33 PM

Le's close it in favour of https://phabricator.kde.org/D10518

stikonas reclaimed this revision.Feb 14 2018, 8:34 PM
stikonas abandoned this revision.Feb 14 2018, 8:52 PM