update handle- icons for kirigami
Needs ReviewPublic

Authored by andreask on Feb 13 2018, 9:01 PM.

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
andreask created this revision.Feb 13 2018, 9:01 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 13 2018, 9:01 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
andreask requested review of this revision.Feb 13 2018, 9:01 PM

the old icon with 12 dots are a bit of a overkill now with three dot's compare to three lines.

needs moar screenshots

This comment was removed by andreask.

Thanks!

I hate to throw cold water on your hard work here, but is the new one really any better? I'm not sure either the old or the new icon convey "swipe left here".

sorry wrong screenshot
left new
right old

ngraham added a comment.EditedFeb 13 2018, 10:07 PM

Same thing, though. The icons on the left don't scream "Swipe me!"

It's a tough one. I have trouble imagining any icon that could communicate that, but of course I'm not an icon designer.

it doesn't matter where the element in kirigami swap it's for settings and have an dotted icon would only increase publicity like here in discover have three dot's in each line will give you the information that you can do something, but the focus is more on the line content than on the dotted icon.

I agree with Andreas and think that the new icon is a huge improvement. +1

it doesn't matter where the element in kirigami swap it's for settings and have an dotted icon would only increase publicity like here in discover have three dot's in each line will give you the information that you can do something, but the focus is more on the line content than on the dotted icon.

Sorry, I don't understand what you mean here, and your screenshot shows the old icon. Can you clarify?

The current icon reminds me of a phone dialer. +1 for the new icon.

+1 for 3-dots icon.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 15 2018, 11:57 PM
This revision was automatically updated to reflect the committed changes.
mart reopened this revision.Feb 21 2018, 6:34 PM

-1, I don't like it at all

mart added a comment.Feb 21 2018, 6:37 PM

i'm fine with simplifying it, but i still want a visual distinction between left and right, which suggests the sliding action (and if on some platform we would decide to make it something else than a slide, we would adapt using a different icon.. just in that case)

Now it has the same icon as the handle for the Context Drawer. On the one hand that's good because they do very similar things, but on the other hand if an app uses both, it could be a bit confusing

mart added a comment.Mar 7 2018, 6:08 PM

As discussed on the channel, the icon should be one of these forms, for me are both ok

In D10494#220993, @mart wrote:

As discussed on the channel, the icon should be one of these forms, for me are both ok

I am for this