Differential D10488

make the navigation bar filter view state a persistent setting
ClosedPublic
Actions

Authored by astippich on Feb 13 2018, 6:59 PM.

Details

Reviewers
mgallien
Group Reviewers
Elisa
Commits
R255:383feeee9d17: make the navigation bar filter view state a persistent setting
Summary

the view state of the navigation action bar is now stored persisently

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich requested review of this revision.Feb 13 2018, 6:59 PM
astippich created this revision.
mgallien accepted this revision.Feb 28 2018, 9:55 PM
mgallien added a subscriber: mgallien.

Thanks for this. I have seen that part of your mail. Sorry for the delay.

There is nothing bad from a quick review. Let's land this and test after.

By the way, is this something you would like to try to automatically test in pure qml ?

This revision is now accepted and ready to land.Feb 28 2018, 9:55 PM
astippich added a comment.Feb 28 2018, 10:59 PM
In D10488#215925, @mgallien wrote:

Thanks for this. I have seen that part of your mail. Sorry for the delay.

There is nothing bad from a quick review. Let's land this and test after.

By the way, is this something you would like to try to automatically test in pure qml ?

Probably a good idea, I should definitely write more tests. I will have a look.

Closed by commit R255:383feeee9d17: make the navigation bar filter view state a persistent setting (authored by astippich). · Explain WhyFeb 28 2018, 11:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28303

View Options

src/qml/ElisaMainWindow.qml

Loading...
View Options

src/qml/GridBrowserView.qml

Loading...
View Options

src/qml/MediaAlbumView.qml

Loading...
View Options

src/qml/MediaAllTracksView.qml

Loading...
View Options

src/qml/NavigationActionBar.qml

Loading...