Added interface to Part class to get blur status
ClosedPublic

Authored by anemeth on Feb 13 2018, 5:07 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Summary

Konsole as a standalone has option to blur behind the window.
With this patch applied an application that uses Konsole as an embedded KPart has an interface to query if the blur is enabled in the current Konsole color profile.

Test Plan

Implemented in Yakuake in D10063

Diff Detail

Repository
R319 Konsole
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
anemeth created this revision.Feb 13 2018, 5:07 PM
Restricted Application added a project: Konsole. · View Herald TranscriptFeb 13 2018, 5:07 PM
Restricted Application added a subscriber: Konsole. · View Herald Transcript
anemeth requested review of this revision.Feb 13 2018, 5:07 PM
anemeth edited the summary of this revision. (Show Details)Feb 13 2018, 5:10 PM
anemeth added reviewers: hindenburg, Konsole.
ngraham edited the test plan for this revision. (Show Details)Feb 13 2018, 5:11 PM

@ngraham This will only affect Yakuake or Dolphin if the they actually use this new function I added.

For Yakuake I will personally make the patch.

For Dolphin I don't think it will be useful.
I couldn't find a way to make the terminal in Dolphin transparent, and even if there is a way I don't think it would look good.
Or maybe I'm just plain wrong and someone implements it properly :)

LGTM - I'll see if I can get my demo to use it

hindenburg accepted this revision.Feb 14 2018, 8:15 PM
This revision is now accepted and ready to land.Feb 14 2018, 8:15 PM
anemeth added a comment.EditedFeb 15 2018, 7:51 AM

@hindenburg I don't have commit access.
Could you please commit it for me?

hindenburg closed this revision.Mar 1 2018, 3:11 PM

Appears my commit message didn't close this

f498aa3c89160ee7a4b25f813f3cb7f9ff0e0a65