Polish ToolBarApplicationHeader appearance
ClosedPublic

Authored by ngraham on Feb 13 2018, 3:29 PM.

Details

Summary
  • Increase the toolbar height by 4 pixels, to make it look less cramped and give items inside it more vertical padding
  • Give the navigation buttons some padding

Supports T7958: Adopt Kirigami ToolBarApplicationHeader

Test Plan

Tested with Discover.

Before:

After:

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Feb 13 2018, 3:29 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptFeb 13 2018, 3:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 13 2018, 3:29 PM
ngraham edited the test plan for this revision. (Show Details)Feb 13 2018, 3:29 PM
ngraham edited the summary of this revision. (Show Details)Feb 13 2018, 4:02 PM
abetts added a subscriber: abetts.Feb 13 2018, 4:05 PM

Sorry guys, this proposed left alignment just won't work IMHO. The reason is that we are turning the bar into a CSD. Unlike a desktop application, we don't have the ability to shrink the application in mobile. What this amounts to is that people will want to add more controls to the top bar, this will cram the interface and the limited space will run out. Pushing the title to the left doesn't work either, it will bump into the back button. I feel it is best that we drop this conversation for now and focus on the HIG first where we can address these ideas first and then try to adjust applications to it.

mart added a comment.Feb 13 2018, 4:52 PM

Sorry guys, this proposed left alignment just won't work IMHO. The reason is that we are turning the bar into a CSD. Unlike a desktop application, we don't have the ability to shrink the application in mobile. What this amounts to is that people will want to add more controls to the top bar, this will cram the interface and the limited space will run out. Pushing the title to the left doesn't work either, it will bump into the back button. I feel it is best that we drop this conversation for now and focus on the HIG first where we can address these ideas first and then try to adjust applications to it.

this look is strictly for desktop:
on mobile, the top bar contents are completely different, is a breadcrumb
and the actions are floating at bottom

ngraham updated this revision to Diff 27096.Feb 13 2018, 7:40 PM

Revert change to center title

ngraham edited the summary of this revision. (Show Details)Feb 13 2018, 7:41 PM

I've reverted the title alignment changes for now. There are too many patches in flight to keep up! If this is good, let's land it (and also Aleix's patches once they're all good too) and then I'll iterate on the titles a bit more. Does that sound like a plan?

mart accepted this revision.Feb 13 2018, 7:47 PM
This revision is now accepted and ready to land.Feb 13 2018, 7:47 PM
This revision was automatically updated to reflect the committed changes.