Differential D10482

Add an isNull() check before setting wheter QIcon is a mask
ClosedPublic
Actions

Authored by icota on Feb 13 2018, 2:38 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:31904e0d74fc: Add an isNull() check before setting wheter QIcon is a mask
Summary

To avoid stepping on a null QIcon. This can happen when calling ::fromTheme with a icon name that doesn't exist on the platform

Diff Detail

Repository
R169 Kirigami
Lint
Lint Skipped
Unit
Unit Tests Skipped
icota created this revision.Feb 13 2018, 2:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptFeb 13 2018, 2:38 PM
icota requested review of this revision.Feb 13 2018, 2:38 PM
mart accepted this revision.Feb 15 2018, 11:19 AM
This revision is now accepted and ready to land.Feb 15 2018, 11:19 AM
icota closed this revision.Feb 16 2018, 11:05 PM

Revision Contents
Changeset List

PathPackages
Msrc/libkirigami/platformtheme.cpp (2 lines)

Diff 27065

View Options

src/libkirigami/platformtheme.cpp

Loading...