Differential D10470

Add action to open screenshots folder to tools menu
ClosedPublic
Actions

Authored by rkflx on Feb 12 2018, 5:50 PM.

Details

Reviewers
ngraham
Group Reviewers
Spectacle
Maniphest Tasks
T7841: Revamp buttons on the bottom to solve various usability issues
Commits
R166:7034b50c5c9e: Add action to open screenshots folder to tools menu
Summary

With Quit after Save or Copy checked, there is a desktop
notification when saving which allows to open the folder containing the
saved screenshot. However, when the user opts to let the window stay
open, only the title will reflect the filename of the saved screenshot.
It's quite hard to know in which folder it was saved and not that easy
to open that folder.

By introducing Tools → Open Screenshots Folder, usability in that
regard is much-improved. When no screenshot has been saved yet, it will
open the last Save As folder or the default Save location
depending on the button state. As soon as a screenshot is saved, the
new action will highlight the new screenshot in the filemanager.

BUG: 389695

Depends on D10467
Ref T7841

Test Plan

For Save and Save As each, click on new menu entry after
starting Spectacle as well as after saving. Also test everything with
fish:/ (but beware of Bug 390297).

Diff Detail

Repository
R166 Spectacle
Branch
open-screenshots-folder (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
rkflx requested review of this revision.Feb 12 2018, 5:50 PM
rkflx created this revision.
rkflx retitled this revision from addAction to Add action to open screenshots folder to tools menu.Feb 12 2018, 5:52 PM
rkflx edited the summary of this revision. (Show Details)
ngraham accepted this revision.Feb 13 2018, 4:25 AM
ngraham added a subscriber: ngraham.

Lovely, you covered all the corner cases, too. Just one comment about the new string in the docbook.

doc/index.docbook
210

Maybe mention the actual menu item's name here to make it clear what it's referring to, as this menu is going to fill up over time.

This revision is now accepted and ready to land.Feb 13 2018, 4:25 AM
rkflx updated this revision to Diff 27107.EditedFeb 13 2018, 9:22 PM

Thanks for reviewing all patches, glad you like them.

Maybe mention the actual menu item's name here to make it clear what it's referring to, as this menu is going to fill up over time.

Good point. I added something, but it's a bit pointless anyway as D10295 rewrote the whole thing into a word bullet list (which you accepted, BTW), so we'll have to see what we get in the end and whether more fixes are needed. Obviously I cannot depend on both your changes and the other patch at the same time.

Same goes for the whitespace fixes / the tools button setup reorg (we might have to think about the order once all items landed).

rkflx marked an inline comment as done.Feb 13 2018, 9:24 PM
ngraham accepted this revision.Feb 13 2018, 9:45 PM

Sounds good.

Closed by commit R166:7034b50c5c9e: Add action to open screenshots folder to tools menu (authored by rkflx). · Explain WhyFeb 14 2018, 10:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27107

View Options

doc/index.docbook

Loading...
View Options

src/ExportManager.h

Loading...
View Options

src/ExportManager.cpp

Loading...
View Options

src/Gui/KSMainWindow.h

Loading...
View Options

src/Gui/KSMainWindow.cpp

Loading...