Improve usability of Save dropdown button

Authored by rkflx on Feb 12 2018, 5:41 PM.



The Save button allows to both Save and Save As.
Instead of showing one option on the button and one option in the menu,
we now always show both options in the menu while keeping the default
state on the button.

This makes the button easier to use, because:

  • The menu always looks the same.
  • It's clear which options are available and which is the default.
  • Both shortcuts are displayed.
  • A menu with a single item is awkward.
  • Okular's selection dropdown button shows all options in the menu too.

Depends on D10467
Ref T7841

Test Plan

Both options still work as before and the last-used button is set as the

Diff Detail

R166 Spectacle
save-button-better-dropdown (branched from master)
No Linters Available
No Unit Test Coverage
rkflx requested review of this revision.Feb 12 2018, 5:41 PM
rkflx created this revision.

+1 on the design. Will test later tonight.

ngraham accepted this revision.Feb 13 2018, 4:28 AM

Approved! That little menu did look a bit sad with only one entry in it.

This revision is now accepted and ready to land.Feb 13 2018, 4:28 AM
This revision was automatically updated to reflect the committed changes.