[WIP/RFC] Consistently use a Toolbar for headers
AbandonedPublic

Authored by ngraham on Feb 12 2018, 3:10 PM.

Details

Reviewers
abetts
apol
Group Reviewers
Discover Software Store
Summary

BUG: 385973

Use a consistent ToolBar for every page's header, with the same background color, height, and text size. This yields the following benefits:

  • Eliminate user complaints about image banner headers
  • Add an area to place UI controls, such as the much-requested sort order menu button (https://bugs.kde.org/show_bug.cgi?id=383518)
  • Increase internal UI consistency; now everything uses the same header style except for the main Featured page (which I think deserves a banner, just with a better image)
  • Widescreen mode looks better because each view doesn't have its own header style

Also remove the redundant app name from the App page's header, and make the back button a standard button to visually balance the header

TBD: implement the same style for the search page

Test Plan

Application browse list, before:

Application browse list, after:

App page, before:

App page, after:

Widescreen mode with app page open, before:

Widescreen mode with app page open, after:

Installed page, before:

Installed page, after:

Settings page, before:

Settings page, after:

Updates page, before:

Updates page, after:

Diff Detail

Repository
R134 Discover Software Store
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Feb 12 2018, 3:10 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 12 2018, 3:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 12 2018, 3:10 PM
ngraham edited the summary of this revision. (Show Details)Feb 12 2018, 3:25 PM
ngraham edited the test plan for this revision. (Show Details)
ngraham retitled this revision from Consistently use a Toolbar for headers to [WIP/RFC] Consistently use a Toolbar for headers.Feb 12 2018, 3:31 PM
ngraham edited the summary of this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)
apol added a comment.Feb 12 2018, 3:49 PM

If we're to do this, I'd very much prefer to use kirigami's native header.

As long as it looks good on the desktop too (or we can make it look good on the desktop too), I'm okay with that. Does it look and behave acceptably right now?

Definitely a step into the right direction. Thumbs up.

Abandoning in favor of D10471: Use Kirgami.ToolBarApplicationHeader instead of the view headers, which is a saner and more sustainable way to do the same thing, and will also yield benefits for other Kirigami consumers because we'll to do some work to improve the Kirigami components to make them suitable for use here.

ngraham abandoned this revision.Feb 13 2018, 12:24 AM