Remove online job view if not needed
ClosedPublic

Authored by tbaumgart on Feb 12 2018, 11:27 AM.

Details

Summary

In case no online job plugin is available, the online job view is not
needed. This change removes the view from the application in case no
online plugin is active at startup of the application.

BUG: 377760
FIXED-IN: 5.0.1

Test Plan

Disable KBanking and OFX plugin and check that page is not shown. Enable at least one of them to have the page back after the next application start.

Diff Detail

Repository
R261 KMyMoney
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tbaumgart requested review of this revision.Feb 12 2018, 11:27 AM
tbaumgart created this revision.
wojnilowicz accepted this revision.Feb 12 2018, 1:49 PM

It's OK for me, but I would pluginize this view eventually.

This revision is now accepted and ready to land.Feb 12 2018, 1:49 PM

Agreed, a long term solution would be to even plug it in and out when an online plugin is activated without restarting the application. I just did not feel to go the extra mile right now.

This revision was automatically updated to reflect the committed changes.