| astippich |
| Elisa |
now adding albums from AllAlbumsProxyModel is fast
when adding tracks from the proxy models, use a working thread and
signals
this means that the main thread and the interface is no longer blocked
adds new methods to MediaPlayList to add list of albums or list of
tracks or list of artists
adding a lot of tracks or artists is still very slow and blocks the
interface
include QtConcurrentRun instead of QtConcurrent (suggested by ebn.kde.org)
enqueue a lot of tracks is now much faster
The tracks or the albums are still added to the playlist but much faster and without blocking the UI.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Thanks for cleaning up the mess I caused :)
Works fine and is indeed very fast. I just noticed when using the replace and play button, the mediaplaylist shortly shows the text of an empty playlist, probably because the clearplaylist command gets executed instantly while the rest still takes a short amount of time.
| src/mediaplaylist.h | ||
|---|---|---|
| 238 | why name this one differently? | |
It is a very good feature that I use quite a lot and really appreciate.
Works fine and is indeed very fast. I just noticed when using the replace and play button, the mediaplaylist shortly shows the text of an empty playlist, probably because the clearplaylist command gets executed instantly while the rest still takes a short amount of time.
Yes, I will have to think about that. The code that adds the new tracks is effectively fully asynchronous. We could maybe delay the clearing to the time we add the tracks (a bit like a replace).
| src/mediaplaylist.h | ||
|---|---|---|
| 238 | I have the problem that an overload with a string list already exists. I should probably rename all the others. That would be easier to understand. | |
does not compile here
| src/elisautils.h | ||
|---|---|---|
| 43 | Qt Creator complains "expected a declaration" | |
What is your compile error ?
Is it only the problem related to QtCreator ?
| src/elisautils.h | ||
|---|---|---|
| 43 | This is https://bugreports.qt.io/browse/QTCREATORBUG-17850 . Should not be really a problem. | |
The error is
elisa/src/main.cpp:-1: error: undefined reference to `ElisaUtils::staticMetaObject'
I've cleaned and completely rebuilt the source.
Thanks I will work on a solution. Sorry for the inconvenience, on my laptop I do not reproduce this situation.
Could you give me the full error message ?
I am not able to understand where it comes from.