drosca retitled this revision from Emit PalleteChanged when setting colors from look and feel package to Emit PaletteChanged when setting colors from look and feel package.Feb 29 2016, 11:04 PM

drosca updated this object.

graesslin added a subscriber: graesslin.Mar 1 2016, 6:36 AM

graesslin added inline comments.

kcms/lookandfeel/kcm.cpp
342	isn't there a way which does not require kdelibs4support?

mart accepted this revision.Mar 1 2016, 8:42 AM

mart added a reviewer: mart.

This revision is now accepted and ready to land.Mar 1 2016, 8:42 AM

drosca added inline comments.Mar 1 2016, 10:47 AM

kcms/lookandfeel/kcm.cpp
342	Yes, QDBusMessage::createSignal instead of KGlobalSettings as this just emits one signal. But KGlobalSettings is already used in this file so it doesn't really matter.

Closed by commit R119:ec5e86a51764: Emit PaletteChanged when setting colors from look and feel package (authored by drosca). · Explain WhyMar 1 2016, 12:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kcms/lookandfeel/kcm.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2504	0aff200		Feb 29 2016, 11:02 PM	★	★
Diff 2	2507	1f5eb9f	rPLASMADESKTOPec5e86a51764e2540ac3d01e589cceafe2c7d5a1	Mar 1 2016, 12:04 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
8d9dd31eef2b	6bd891446dd8	0aff2004d2ac	David Rosca	Emit PalleteChanged when setting colors from look and feel package (Show More…)	Feb 29 2016, 10:59 PM

Diff 2507

View Options

Emit PaletteChanged when setting colors from look and feel packageClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 2507

kcms/lookandfeel/kcm.cpp

Emit PaletteChanged when setting colors from look and feel package
ClosedPublic
Actions

Revision Contents
Changeset List