Add a profile property to toggle copying text as HTML
ClosedPublic

Authored by ahmadsamir on Feb 11 2018, 7:35 PM.

Details

Summary

Add a profile property to toggle copying text as HTML.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Feb 11 2018, 7:35 PM
Restricted Application added a project: Konsole. · View Herald TranscriptFeb 11 2018, 7:35 PM
Restricted Application added a subscriber: Konsole. · View Herald Transcript
ahmadsamir requested review of this revision.Feb 11 2018, 7:35 PM
hindenburg added a comment.EditedFeb 12 2018, 3:51 PM

In general, this is fine - however, I wonder if people will get confused as the HTML pasting only works in certain applications.

Perhaps reverse this - copy as plain text

src/EditProfileDialog.ui
10

remove this - when using designer, it will often changes things

ahmadsamir marked an inline comment as done.EditedFeb 12 2018, 5:04 PM

In general, this is fine - however, I wonder if people will get confused as the HTML pasting only works in certain applications.

Perhaps reverse this - copy as plain text

I don't think it'll be a problem, because people have been copying text from web browsers for a long time, the text is usually formatted (font faces, colors... etc) and it's reasonable/expected that if they paste it in a plain text editor they'll get plain text, the formatting won't be kept.

ahmadsamir updated this revision to Diff 27013.Feb 12 2018, 5:05 PM

Remove redundant changes inserted by Designer in the .ui file.

hindenburg added inline comments.Feb 13 2018, 9:54 PM
src/TerminalDisplay.cpp
357

we want the default to be true correctly, as it is currently?

ahmadsamir added inline comments.Feb 14 2018, 5:46 AM
src/TerminalDisplay.cpp
357

I think it should be opt-in; I think most users, me included, expect that text copied from a terminal emulator is going to be plain/text...

hindenburg added inline comments.Feb 14 2018, 6:06 PM
src/TerminalDisplay.cpp
357

I would prefer to not change the default from what it is now . If they don't like the current way this works, they change change this setting.

ahmadsamir updated this revision to Diff 27178.Feb 14 2018, 6:50 PM

Keep the current default of copying text as HTML.

ahmadsamir marked 3 inline comments as done.Feb 14 2018, 6:51 PM
hindenburg accepted this revision.Feb 14 2018, 7:39 PM
This revision is now accepted and ready to land.Feb 14 2018, 7:39 PM
This revision was automatically updated to reflect the committed changes.