Differential D10439

Use QFileInfo::completeBaseName() to handle files with more than one dot in their names.
ClosedPublic
Actions

Authored by ahmadsamir on Feb 11 2018, 9:13 AM.

Details

Reviewers
hindenburg
Commits
R319:a7c3bda7a5e2: Use QFileInfo::completeBaseName() instead of baseName()
Summary

This fixes an infinite loop in findColorScheme() when it calls loadColorScheme();
fixes konsole BUG: 343071

Also apply a similar change to BookmarkHandler::titleForView() and
KeyboardTranslatorManager::findTranslators()

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Feb 11 2018, 9:13 AM
Restricted Application added a project: Konsole. · View Herald TranscriptFeb 11 2018, 9:13 AM
Restricted Application added a subscriber: Konsole. · View Herald Transcript
ahmadsamir requested review of this revision.Feb 11 2018, 9:13 AM
hindenburg added a comment.Feb 11 2018, 4:09 PM

Thanks, there's a lot of old bugs that I don't recall even seeing.

I don't think you need to mentioned the BUG # or the "use complete..." part for each of these. These will both be in the commit message which anyone could look at.

ahmadsamir updated this revision to Diff 26941.Feb 11 2018, 4:56 PM

Less comments in the source files.

ahmadsamir added a comment.Feb 11 2018, 4:57 PM
In D10439#204483, @hindenburg wrote:

Thanks, there's a lot of old bugs that I don't recall even seeing.

There are usually more bugs than there's time :)

This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2018, 2:44 PM
Closed by commit R319:a7c3bda7a5e2: Use QFileInfo::completeBaseName() instead of baseName() (authored by hindenburg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27000

View Options

src/BookmarkHandler.cpp

Loading...
View Options

src/ColorSchemeManager.cpp

Loading...
View Options

src/KeyboardTranslatorManager.cpp

Loading...