Pluginize forecast view
ClosedPublic
Actions

Authored by wojnilowicz on Feb 10 2018, 5:14 PM.

Details

Reviewers

Commits

R261:c94c502b60f0: Pluginize forecast view

Summary

This patch makes forecast view optional instead of mandatory. User can switch on and off this view and have more space on views pane.
Developers will benefit by saving on build time of this plugin.

Pluginization is not yet perfect, but it will be polished with time.

Diff Detail

Repository

R261 KMyMoney

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

wojnilowicz requested review of this revision.Feb 10 2018, 5:14 PM

wojnilowicz created this revision.

This patch does not apply on current master :( Can you update the patch?

kmymoney/views/kmymoneyview.h
129	Remove this line, we don't need it anymore

This revision now requires changes to proceed.Feb 10 2018, 7:02 PM

In D10428#204067, @tbaumgart wrote:

This patch does not apply on current master :( Can you update the patch?

Probably because it's based on D10406. Let's do it step by step, so we won't be lost in chaos.

wojnilowicz updated this revision to Diff 26904.Feb 11 2018, 8:24 AM

Otherwise, it looks OK to me,Please go ahead and land it as I need to rework my settings patch after this is available.

kmymoney/views/kmymoneyview.h
69	Remove if we don't need it anymore

This revision is now accepted and ready to land.Feb 18 2018, 7:26 AM

Closed by commit R261:c94c502b60f0: Pluginize forecast view (authored by wojnilowicz). · Explain WhyFeb 18 2018, 2:34 PM

This revision was automatically updated to reflect the committed changes.

wojnilowicz marked an inline comment as done.Feb 18 2018, 2:41 PM

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (2 lines)
M		kmymoney/CMakeLists.txt (1 line)
M		kmymoney/dialogs/settings/CMakeLists.txt (2 lines)
P		kmymoney/dialogs/settings/ksettingsforecast.h Deleted after being copied to multiple locations: kmymoney/plugins/forecast/forecastview.h kmymoney/plugins/forecast/ksettingsforecast.h
V		kmymoney/{dialogs/settings → plugins/forecast}/ksettingsforecast.cpp
V		kmymoney/{dialogs/settings/ksettingsforecast.ui → plugins/forecast/forecastviewsettings.ui}
M		kmymoney/dialogs/settings/ksettingskmymoney.cpp (3 lines)
M		kmymoney/kmymoney.kcfg (46 lines)
M		kmymoney/kmymoneyglobalsettings.h (2 lines)
M		kmymoney/kmymoneyglobalsettings.cpp (27 lines)
M		kmymoney/plugins/CMakeLists.txt (4 lines)
A	M	kmymoney/plugins/forecast/CMakeLists.txt (51 lines)
V		kmymoney/{plugins/forecast ← widgets}/fixedcolumntreeview.h
V		kmymoney/{plugins/forecast ← widgets}/fixedcolumntreeview.cpp
P		kmymoney/plugins/forecast/forecastview.h (38 lines) Copied from kmymoney/dialogs/settings/ksettingsforecast.h
A	M	kmymoney/plugins/forecast/forecastview.cpp (68 lines)
A	M	kmymoney/plugins/forecast/forecastview.json.in (21 lines)
A	M	kmymoney/plugins/forecast/forecastviewsettings.kcfg (54 lines)
A	M	kmymoney/plugins/forecast/forecastviewsettings.kcfgc (6 lines)
V		kmymoney/{plugins/forecast/forecastviewsettings.ui ← dialogs/settings/ksettingsforecast.ui} (4 lines)
A	M	kmymoney/plugins/forecast/kcm_forecastview.h (42 lines)
A	M	kmymoney/plugins/forecast/kcm_forecastview.cpp (53 lines)
A	M	kmymoney/plugins/forecast/kcm_forecastview.desktop (15 lines)
V		kmymoney/{plugins/forecast ← views}/kforecastview.h (2 lines)
V		kmymoney/{plugins/forecast ← views}/kforecastview.cpp
V		kmymoney/{plugins/forecast ← views}/kforecastview.ui
V		kmymoney/{plugins/forecast ← views}/kforecastview_p.h (13 lines)
V		kmymoney/{plugins/forecast ← dialogs/settings}/ksettingsforecast.h
V		kmymoney/{plugins/forecast ← dialogs/settings}/ksettingsforecast.cpp
M		kmymoney/plugins/interfaces/kmmviewinterface.h (2 lines)
M		kmymoney/plugins/interfaces/kmmviewinterface.cpp (10 lines)
M		kmymoney/plugins/viewinterface.h (6 lines)
M		kmymoney/views/CMakeLists.txt (14 lines)
V		kmymoney/{views → plugins/forecast}/kforecastview.h
V		kmymoney/{views → plugins/forecast}/kforecastview.cpp
V		kmymoney/{views → plugins/forecast}/kforecastview.ui
V		kmymoney/{views → plugins/forecast}/kforecastview_p.h
M		kmymoney/views/kmymoneyview.h (10 lines)
M		kmymoney/views/kmymoneyview.cpp (82 lines)
M		kmymoney/widgets/CMakeLists.txt (1 line)
V		kmymoney/{widgets → plugins/forecast}/fixedcolumntreeview.h
V		kmymoney/{widgets → plugins/forecast}/fixedcolumntreeview.cpp

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	26882			Feb 10 2018, 5:13 PM	★	★
Diff 2	26904			Feb 11 2018, 8:24 AM	★	★
Diff 3	27468	5adcba3	R261:c94c502b60f0df7f72541023955c0eb0bc3bb109	Feb 18 2018, 2:33 PM	★	★