BUG: 389694
Details
Details
Spectacle's Save & Quit item now always totally exits Spectacle after the notification goes away
Steps to reproduce (taken from the bug):
- $ spectacle
- Save & Exit
- Configure Notifications in Plasma popup, Cancel
- Spectacle returns to the shell prompt instead of keeping running in the shell
Diff Detail
Diff Detail
- Repository
- R166 Spectacle
- Branch
- arcpatch-D10424
- Lint
No Linters Available - Unit
No Unit Test Coverage
| src/Main.cpp | ||
|---|---|---|
| 143 | I don't get the difference..? | |
| src/Main.cpp | ||
|---|---|---|
| 143 | Me neither, but somehow this works for me. | |
| src/Main.cpp | ||
|---|---|---|
| 143 | qApp is setted after calling exec(). So this line should be QObject::connect(&core, &SpectacleCore::allDone, &app, &QApplication::quit); | |
Comment Actions
Thanks for working on this ;)
However, either it's not working for me, or you should improve your test plan so it has instructions for reproducing behaviour which is broken without your patch and fixed with your patch.
It's been implemented this way to make sure that Spectacle doesn't quit before its notification appears on the screen, but there's doubtless a better way to do this.
Do you know why this is a requirement, i.e. does the notification break when we quit right away? How are other apps handling this?
See also D10301#204185, where it seems to work in one case.
Comment Actions
For me, without the patch, Save & Exit is always broken in the way indicated in the Bugzilla ticket, and with the patch, Save & Exit always works.
It's been implemented this way to make sure that Spectacle doesn't quit before its notification appears on the screen, but there's doubtless a better way to do this.
Do you know why this is a requirement, i.e. does the notification break when we quit right away?
Yes, without the existing workaround/implementation in Spectacle, the app quits before the notification appears.
How are other apps handling this?
I don't know.
Comment Actions
I tried again for quite some time, but for me the patch does not change anything at all.
Note again that with D10301, I get Save As to exit immediately while also showing the notification. Could we get every operation to behave like that?