Differential D10420

Make sure the FrameSvg and Svg instances have the right devicePixelRatio
ClosedPublic
Actions

Authored by apol on Feb 10 2018, 12:26 AM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R242:3e4b26452aeb: Make sure the FrameSvg and Svg instances have the right devicePixelRatio
Summary

On wayland (at least) it's initialized when the window is assigned, so
we need to listen to the itemChanged to adopt it.

Test Plan

manual testing

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Feb 10 2018, 12:26 AM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptFeb 10 2018, 12:26 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
apol requested review of this revision.Feb 10 2018, 12:26 AM
hein added a subscriber: hein.Feb 11 2018, 8:18 AM

Sanity check question: Did you make sure this doesn't introduce an extra render when things start up? (Initial vs. change.)

Otherwise makes sense (and finally fixes some Wayland uglyness I've been annoyed by ...).

apol added a comment.Feb 12 2018, 1:13 PM
In D10420#204235, @hein wrote:

Sanity check question: Did you make sure this doesn't introduce an extra render when things start up? (Initial vs. change.)

Otherwise makes sense (and finally fixes some Wayland uglyness I've been annoyed by ...).

Only should be adding an extra rendering cycle if it was rendered with the wrong dpi, so it's something we need anyway.

hein accepted this revision.Feb 12 2018, 1:14 PM
This revision is now accepted and ready to land.Feb 12 2018, 1:14 PM
Closed by commit R242:3e4b26452aeb: Make sure the FrameSvg and Svg instances have the right devicePixelRatio (authored by apol). · Explain WhyFeb 12 2018, 1:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 26993

View Options

src/declarativeimports/core/framesvgitem.h

Loading...
View Options

src/declarativeimports/core/framesvgitem.cpp

Loading...
View Options

src/declarativeimports/core/iconitem.cpp

Loading...