Differential D10395

Use plasmoid.icon instead of Logic.icon()
ClosedPublic
Actions

Authored by broulik on Feb 8 2018, 9:52 PM.

Details

Reviewers
drosca
Group Reviewers
Plasma
Commits
R97:2c5de6e121b5: Use plasmoid.icon instead of Logic.icon()
Summary

Avoid creating an instance of logic.js which is not a singleton.

Test Plan

Bluetooth icon still reflects connected/disconnected state, busy indicator also worked

Diff Detail

Repository
R97 Bluedevil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 8 2018, 9:52 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 8 2018, 9:52 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 8 2018, 9:52 PM
drosca accepted this revision.Feb 9 2018, 7:31 AM
This revision is now accepted and ready to land.Feb 9 2018, 7:31 AM
Closed by commit R97:2c5de6e121b5: Use plasmoid.icon instead of Logic.icon() (authored by broulik). · Explain WhyFeb 12 2018, 3:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27004

View Options

src/applet/package/contents/ui/CompactRepresentation.qml

Loading...