Differential D10379

Add detection of the Meta/Super key press
ClosedPublic
Actions

Authored by bobli on Feb 8 2018, 12:18 AM.

Details

Reviewers
albertvaka
nicolasfella
Group Reviewers
KDE Connect
Commits
R224:a685a4910e0b: Add detection of the Meta/Super key press
R225:8c48df62936a: Add detection of the Meta/Super key press
Summary

With Hacker's keyboard, it is possible to press the Meta/Super key, however this is not sent via kdeconnect.
The desktop daemon should also be modified to respond to a super field and press the Super key.

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bobli requested review of this revision.Feb 8 2018, 12:18 AM
bobli created this revision.
Restricted Application added a project: KDE Connect. · View Herald TranscriptMay 22 2018, 12:04 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
albertvaka accepted this revision.May 22 2018, 9:49 PM
albertvaka added a subscriber: albertvaka.

Looks good to me. Can you make the changes to the desktop client as well?

This revision is now accepted and ready to land.May 22 2018, 9:49 PM
bobli updated this revision to Diff 42331.Sep 25 2018, 9:24 PM

The c++ desktop daemon supports Super key.

nicolasfella requested changes to this revision.Sep 25 2018, 9:55 PM
nicolasfella added a subscriber: nicolasfella.

Thanks for the follow-up. However, by uploading the desktop patch you've overridden the older Android patch. Please upload the old one again (in a different review request) so we can merge them both

This revision now requires changes to proceed.Sep 25 2018, 9:55 PM
bobli updated this revision to Diff 42333.Sep 25 2018, 9:59 PM
albertvaka added a comment.Oct 2 2018, 11:30 PM

Both patches should be submitted separately, in two review requests, so they can be merged automatically. Also, we don't accept contributions under an alias so we will need your full name to merge this.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 7 2018, 3:06 PM
Closed by commit R225:8c48df62936a: Add detection of the Meta/Super key press (authored by bobli, committed by albertvaka). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45036

View Options

src/org/kde/kdeconnect/Plugins/MousePadPlugin/KeyListenerView.java

Loading...