kio_file: skip error handling for initial perms during file copy
ClosedPublic

Authored by dfaure on Feb 7 2018, 10:23 PM.

Details

Summary

This reverts the parts of 13ab6a85bb which touched this code, there
didn't use to be any error handling for this call, on purpose.
This is just the initial permissions for the newly created file we are
going to copy to; if the filesystem doesn't support permissions, we can
still proceed.

Test Plan

Copying a file to a VFAT partition no longer leads to an empty file.

Diff Detail

Repository
R241 KIO
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
dfaure created this revision.Feb 7 2018, 10:23 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 7 2018, 10:23 PM
dfaure requested review of this revision.Feb 7 2018, 10:23 PM
jtamate accepted this revision.Feb 8 2018, 7:58 AM

Even moving to a ntfs filesystem without the rights to change owner doesn't end in an empty file.
Very good job.

This revision is now accepted and ready to land.Feb 8 2018, 7:58 AM
dfaure closed this revision.Feb 8 2018, 4:29 PM