Move printing to a new tools button
ClosedPublic

Authored by rkflx on Feb 7 2018, 8:44 PM.

Details

Summary

Print does neither belong to Save nor Save As, so it
goes into a new menu button called Tools. More entries will be
added to the menu in D10295 and possibly in T6321.

In order to gain more horizontal space, Export Image... is renamed
to Export, which is in line with the other buttons not repeating
"image". "..." is removed as it should be only added to the menu entries
itself if necessary and the arrow on the button is enough to indicate
its purpose.

Ref. T7841

Test Plan

  • Printing via the button still works, as well as Ctrl+P.
  • Somewhat sensible icon chosen for the button.
  • Docbook updated.

Diff Detail

Repository
R166 Spectacle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rkflx requested review of this revision.Feb 7 2018, 8:44 PM
rkflx created this revision.
ngraham added a subscriber: ngraham.Feb 7 2018, 8:52 PM

Looks good, just a few comments!

doc/index.docbook
189

Whitespace issue?

205–211

Indentation looks a bit off here.

src/Gui/KSMainWindow.cpp
138

This ends up being a generic Hamburger icon. Any chance we could some up with something a bit more meaningful? Maybe a wrench or gear icon that would go with "Tools" better?

rkflx added inline comments.Feb 7 2018, 9:02 PM
src/Gui/KSMainWindow.cpp
138

I actually looked for exactly that for quite a while before submitting and could not find it. But maybe I missed it? Let me know of any suggestions. This one was the best I could find, and it is used in other places too (Systemsettings, Dolphin).

rkflx updated this revision to Diff 26721.Feb 7 2018, 9:08 PM

Fix whitespace issues.
Seems the editor changed tabs to spaces (why are tabs even used there!?).

rkflx marked 2 inline comments as done.Feb 7 2018, 9:09 PM
rkflx updated this revision to Diff 26725.EditedFeb 7 2018, 10:16 PM

Fix icon so it even displays with Oxygen (where you now have two wrenches, but that's a problem of Oxygen which we should not work around). Breeze still unchanged.

Seems like Breeze has no wrenches or gears at all anymore?

ngraham accepted this revision.Feb 7 2018, 11:28 PM

Fix icon so it even displays with Oxygen (where you now have two wrenches, but that's a problem of Oxygen which we should not work around). Breeze still unchanged.

Seems like Breeze has no wrenches or gears at all anymore?

Huh, you're right. Oh well, I guess the hamburger icon can do. Go for it! Works great.

This revision is now accepted and ready to land.Feb 7 2018, 11:28 PM
rkflx marked 2 inline comments as done.Feb 7 2018, 11:29 PM
This revision was automatically updated to reflect the committed changes.