Easy access to room users
AbandonedPublic
Actions

Authored by plemire on Feb 7 2018, 3:22 PM.

Details

Reviewers

mlaurent

Lint

Lint Skipped

Unit

Unit Tests Skipped

plemire requested review of this revision.Feb 7 2018, 3:22 PM

plemire created this revision.

mlaurent requested changes to this revision.Feb 7 2018, 7:02 PM

mlaurent added inline comments.

src/qml/MainComponent.qml
79	Use i18n("...") for translating string.
181	We need a margin at left/right. Perhaps we need to add "anchors.leftMargin: Kirigami.Units.smallSpacing anchors.rightMargin: Kirigami.Units.smallSpacing"

This revision now requires changes to proceed.Feb 7 2018, 7:02 PM

plemire marked 2 inline comments as done.Feb 15 2018, 4:23 PM

You forgot to upload patch ?:)

			Path	Packages
M			src/qml/MainComponent.qml (24 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	26703			Feb 7 2018, 3:20 PM	★	★