Indicate state, not the action it will have. When the password field is empty it feels like the password will be shown once I start typing. Dolphin has been doing it this way for the "show hidden files" action forever.
Also only show the button when the field contains text or when revealing the password, like in the PolKit dialog.
Details
Empty field
Dolphin
Show hidden files, files are currently hidden
Hide hidden files, files are currently shown
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Branch
- arcpatch-D10362
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 16195 Build 16213: arc lint + arc unit
Would further be also likely more consistent with other toggles in the future, like imagined on mobile "wifi crossed out=disabled", etc.
Hmm I don't know, that's a button and a button should tell me what happens when I click it (Dolphin is also wrong imho).
Would it be possible to implement this feature like in the Windows 10 lock screen? (i.e. don't toggle the state; reveal the password only as long as the button is pressed). I feel like it would remove the security issue in the first place (as there isn't anymore a persistent state where the password can be visible).
-1 for the current version
How am I supposed to type with 2 hands and see the password at the same time if I have to hold down the left mouse button?
+1 for the previous version of the patch
I think the idea is that you're not supposed to be typing with the characters visible as you type because then anyone else who might be around could just see your password. If you're in an environment where security concerns are sufficiently low as to permit this, it would probably make more sense to not even set a password, or use auto-login.
I understand this, but I think this is one of those cases where a marginal increase in security should take a backseat to usability. It's not like people can't quickly hide the password again if they already know about the button. If one is afraid of others looking over their shoulder, they shouldn't use the reveal password button in the first place, regardless of how it functions.
If you're in an environment where security concerns are sufficiently low as to permit this, it would probably make more sense to not even set a password, or use auto-login.
I disagree. Just because you aren't likely to have someone looking over your shoulder, doesn't mean nobody will attempt to access your computer while you're not around.
Change onPressedChanged back to onClicked and only show the button when there is text inside the TextField, like in the PolKit dialog