BUG: 388633
FIXED-IN 5.12.1
Take the device pixel ratio into consideration when rendering the logo, so it looks nice in HighDPI mode.
BUG: 388633
FIXED-IN 5.12.1
Take the device pixel ratio into consideration when rendering the logo, so it looks nice in HighDPI mode.
Tested in NDE Neon
Before:
After:
No Linters Available |
No Unit Test Coverage |
Modules/about-distro/src/Module.cpp | ||
---|---|---|
145 ↗ | (On Diff #26685) | Did you check how it behaves with a distro-provided pixmap? I fear it would become tiny. I don't think we have any kind of @2x support for that |
main.cpp | ||
2 | Unrelated | |
39 | Shouldn't it be Qt::AA_UseHighDpiPixmaps? From what I understood the Qt::AA_EnableHighDpiScaling flag forces high dpi support regardless of environment variables or platform theme. |
main.cpp | ||
---|---|---|
39 | Never did that, app.setAttribute(Qt::AA_UseHighDpiPixmaps, true); works just fine and the docs also don't mention it |
Modules/about-distro/src/Module.cpp | ||
---|---|---|
145 ↗ | (On Diff #26685) | Yes, it still works fine with distro-provided pixmals, at both 1x scale and > 1x scale. |
Suggesting Qt:AA_EnableHighDpiScaling was my fault; I really should have checked our applications to suggest the correct attribute.