some drivers, like Mali have EGL_KHR_platform_gbm
but not EGL_MESA_platform_gbm
Details
Details
- Reviewers
davidedmundson graesslin - Group Reviewers
KWin Plasma - Commits
- R108:8a2b9a014f7d: check for EGL_KHR_platform_gbm extension as well
pending a test on rock64 board
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| plugins/platforms/drm/egl_gbm_backend.cpp | ||
|---|---|---|
| 110 | this is going to crash and burn when you have KHR but not Mesa. You'll need to keep track of which extension you have, and alter any extension specific code accordingly. | |
Comment Actions
- wock which extension we're usingrks both as qwidget and with the qstyle-based qqc2-desktop-style
Comment Actions
BTW this patch works as tested on both the Rock64 and Pinebook, but kwin fails in another place now. Will continue investigating.
| plugins/platforms/drm/egl_gbm_backend.cpp | ||
|---|---|---|
| 110 | which could be as easy as setting a local variable GLenum platform = hasMesaGBM ? EGL_PLATFORM_GBM_MESA : EGL_PLATFORM_GBM_KHR and use this in the eglGetPlatformDisplayEXT call without all the if-else. | |