Differential D1034

[Task Manager] Don't show task is on all activities if there is just one running one
ClosedPublic
Actions

Authored by broulik on Feb 28 2016, 9:03 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:f3c41c272572: [Task Manager] Don't show task is on all activities if there is just one…
Summary

This is similar to what we do with regards to virtual desktops.

Test Plan

VLC player no longer claims to be on all activities if I only have one running activity, suggested by mklapetek

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 2487.Feb 28 2016, 9:03 PM
broulik retitled this revision from to [Task Manager] Don't show task is on all activities if there is just one running one.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
broulik added a project: Plasma.
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptFeb 28 2016, 9:03 PM
hein accepted this revision.Feb 29 2016, 8:40 AM
hein edited edge metadata.
This revision is now accepted and ready to land.Feb 29 2016, 8:40 AM
davidedmundson added a subscriber: davidedmundson.Feb 29 2016, 11:01 AM
davidedmundson added inline comments.
applets/taskmanager/plugin/backend.cpp
635

you've effectively got a race condition as to whether the task delegate is created before or after the activities consumer loads.

Closed by commit R119:f3c41c272572: [Task Manager] Don't show task is on all activities if there is just one… (authored by broulik). · Explain WhyFeb 29 2016, 12:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2493

View Options

applets/taskmanager/package/contents/ui/Task.qml

Loading...
View Options

applets/taskmanager/plugin/backend.h

Loading...
View Options

applets/taskmanager/plugin/backend.cpp

Loading...