Differential D10336

[Quick Editor] Don't clear before rendering
ClosedPublic
Actions

Authored by broulik on Feb 6 2018, 10:42 AM.

Details

Reviewers
bgupta
davidedmundson
ngraham
Group Reviewers
Spectacle
Commits
R166:84260984aa7a: [Quick Editor] Don't clear before rendering
Summary

We always put a full size Image and Canvas ontop, no need to clear it before.

Test Plan

Improves performance of the editor, notable moving the selection around, somewhat.

Diff Detail

Repository
R166 Spectacle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik requested review of this revision.Feb 6 2018, 10:42 AM
broulik created this revision.
rkflx added a reviewer: Spectacle.Feb 12 2018, 6:27 PM
rkflx added a subscriber: rkflx.

I should add more subtle complaints here and there if this magically results in fixes. Thanks!

Looked at the code and tried to break it, but all is fine.

As for the performance: I could not really tell a difference, but if it is faster for you, there's no harm in landing. I'll let Spectacle's members have the final say.

ngraham accepted this revision.Feb 13 2018, 3:23 AM
ngraham added a subscriber: ngraham.

Looks fine to me too. Couldn't make it explode in testing.

This revision is now accepted and ready to land.Feb 13 2018, 3:23 AM
Closed by commit R166:84260984aa7a: [Quick Editor] Don't clear before rendering (authored by broulik). · Explain WhyFeb 15 2018, 12:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/QuickEditor/QuickEditor.cpp (1 line)

Diff 27246

View Options

src/QuickEditor/QuickEditor.cpp

Loading...