Differential D10329

[KUrlNavigatorPlacesSelector] Put categories into submenus
ClosedPublic
Actions

Authored by broulik on Feb 5 2018, 4:26 PM.

Details

Reviewers
dfaure
Group Reviewers
VDG
Frameworks
Commits
R241:03be39f3709e: [KUrlNavigatorPlacesSelector] Put categories into submenus
Summary

Avoids letting the menu get huge. This is a straight port from Plasma's task manager 6effcdf11d1a64017593c5cef434b80122936854
Also hide hidden items.

BUG: 389635

Test Plan

There's no way to access hidden items from this menu, however. You would need to unhide them in the places panel.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 5 2018, 4:26 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 5 2018, 4:26 PM
broulik requested review of this revision.Feb 5 2018, 4:26 PM
broulik updated this revision to Diff 26598.Feb 5 2018, 4:37 PM
  • Install middle click for new tab event filter also on sub menu
ngraham accepted this revision as: VDG.Feb 5 2018, 4:52 PM
ngraham added a subscriber: ngraham.

Strongly approve. This improves organization, prevents the menu from becoming huge when there are a lot of items, and also eliminates one objection to D10245.

michaelh added a subscriber: michaelh.Feb 12 2018, 4:08 PM

+1 Looking forward to it.

abetts added a subscriber: abetts.Feb 12 2018, 4:09 PM

Will this hide "All" menu items or will it hide after a certain amount of them are in the menu? For example, it will turn into a sub menu after 3 items?

ngraham added a comment.Feb 12 2018, 4:22 PM

The Places panel items are always visible without a submenu, so there should never be a situation where the menu consists entirely of submenus.

dfaure accepted this revision.Feb 19 2018, 8:38 AM
This revision is now accepted and ready to land.Feb 19 2018, 8:38 AM
Closed by commit R241:03be39f3709e: [KUrlNavigatorPlacesSelector] Put categories into submenus (authored by broulik). · Explain WhyFeb 19 2018, 9:09 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27522

View Options

src/filewidgets/kurlnavigatorplacesselector.cpp

Loading...