[LauncherTasksModel] Support applications: URLs in requestOpenUrls
ClosedPublic

Authored by broulik on Feb 5 2018, 3:51 PM.

Details

Summary

Also fix a logic error while at it.

Test Plan

I noticed that it would crash when I dropped a file onto my Kate launcher. Then I found the logic bug, and then I found that the entire thing actually didn't work because we forgot applications: special URL handling

I can now drop a file onto my Kate launcher again and it opens it in Kate. When app is running dropping still works. Multiple files also work.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 5 2018, 3:51 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 5 2018, 3:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 5 2018, 3:51 PM
hein accepted this revision.Feb 6 2018, 6:08 AM

I can't help but feel increasingly bad about the whole applications: URLs thing. If we have to patch 5000 places something is not right. We need to come up with a better way some time soon. What are we doing wrong? Maybe we should just pass KServices around? Hmm.

In the meantime, this patch fixes a bug, so +1.

This revision is now accepted and ready to land.Feb 6 2018, 6:08 AM
This revision was automatically updated to reflect the committed changes.