Angle tweaks to hatching engine

Authored by snansandra on Feb 5 2018, 12:20 PM.



I guess these have to wait until after the string freeze but it changes some corner cases in the Hatching engine and adds the angle parameter.

Discussed here.

Test Plan

What's that!?

Diff Detail

R37 Krita
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
snansandra created this revision.Feb 5 2018, 12:20 PM
Restricted Application added a subscriber: woltherav. · View Herald TranscriptFeb 5 2018, 12:20 PM
snansandra requested review of this revision.Feb 5 2018, 12:20 PM
rempt added a subscriber: rempt.Feb 6 2018, 8:09 AM

Aw... The patch is missing the new kis_hatching_pressure_angle_option.cpp/h files :-(.

snansandra added a comment.EditedFeb 6 2018, 8:13 AM

A git snafu. Should I start over with a new patch or can I append to this somehow? First time using Phabricator. Edit: I tried updating it, hope that was the right thing to do

snansandra updated this revision to Diff 26628.Feb 6 2018, 8:16 AM

Added the two forgotten files.

rempt added a comment.Feb 6 2018, 8:19 AM

Ah, you figured it out before I saw your update :-)

rempt accepted this revision.Feb 6 2018, 8:50 AM

Yes, this seems to work fine. I think we can even push it to master, since the only string is "Angle", and already occurs in Krita in quite a few places, so it's not a new translation.

This revision is now accepted and ready to land.Feb 6 2018, 8:50 AM
This revision was automatically updated to reflect the committed changes.