Differential D10317

POP3 resource: Option to use system proxy settings (Core part)
ClosedPublic
Actions

Authored by marten on Feb 5 2018, 9:11 AM.

Details

Reviewers

mlaurent

Group Reviewers

KDE PIM

Commits

R44:08c5e8544853: Explicit option to use the system proxy setting for POP3 connections

Summary

This is to provide an explicit option to not use the system proxy setting for POP3 connections, as described in T7430.

If the system proxy settings are set to use the environment variables http_proxy etc (for compatibility with non-KDE applications), then they are also used for POP3 connections. This is rarely required and will fail unless the proxy is transparent enough. See https://bugs.kde.org/show_bug.cgi?id=373870 and related bugs.

This change adds a POP3 account option to use the proxy for connection (the default is off). This is the core part of the change; the visible GUI part will follow in another diff.

Test Plan

Built pimruntime with this change, verified that by default the POP3 connection is not made via the proxy and that mail fetching works as expected. Verified that, if the option is set, the POP3 connection is made via the proxy.

Diff Detail

Repository

R44 KDE PIM Runtime

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

marten created this revision.Feb 5 2018, 9:11 AM

Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 5 2018, 9:11 AM

marten requested review of this revision.Feb 5 2018, 9:11 AM

marten mentioned this in D10318: POP3 resource: Option to use system proxy settings (GUI part).Feb 5 2018, 9:16 AM

mlaurent added a subscriber: mlaurent.Feb 5 2018, 11:49 AM

mlaurent added inline comments.

kioslave/pop3/pop3.cpp
619	coding style if(...) {
624	if (sock) {
630	} else { ... }

mlaurent requested changes to this revision.Feb 5 2018, 11:49 AM

This revision now requires changes to proceed.Feb 5 2018, 11:49 AM

Diff updated for coding style, in accordance with review comments.

marten marked 3 inline comments as done.Feb 5 2018, 2:05 PM

mlaurent accepted this revision.Feb 5 2018, 9:00 PM

This revision is now accepted and ready to land.Feb 5 2018, 9:00 PM

Closed by commit R44:08c5e8544853: Explicit option to use the system proxy setting for POP3 connections (authored by marten). · Explain WhyFeb 6 2018, 4:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kioslave/pop3/CMakeLists.txt (2 lines)
M			kioslave/pop3/pop3.cpp (17 lines)
M			resources/pop3/jobs.cpp (2 lines)
M			resources/pop3/settings.kcfg (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	26564			Feb 5 2018, 9:01 AM	★	★
Diff 2	26580			Feb 5 2018, 2:04 PM	★	★
Diff 3	26656	29aacfd	R44:08c5e85448532653374fb57231bd3effdd64b4d4	Feb 6 2018, 4:08 PM	★	★