POP3 resource: Option to use system proxy settings (Core part)

Authored by marten on Feb 5 2018, 9:11 AM.



This is to provide an explicit option to not use the system proxy setting for POP3 connections, as described in T7430.

If the system proxy settings are set to use the environment variables http_proxy etc (for compatibility with non-KDE applications), then they are also used for POP3 connections. This is rarely required and will fail unless the proxy is transparent enough. See https://bugs.kde.org/show_bug.cgi?id=373870 and related bugs.

This change adds a POP3 account option to use the proxy for connection (the default is off). This is the core part of the change; the visible GUI part will follow in another diff.

Test Plan

Built pimruntime with this change, verified that by default the POP3 connection is not made via the proxy and that mail fetching works as expected. Verified that, if the option is set, the POP3 connection is made via the proxy.

Diff Detail

R44 KDE PIM Runtime
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
marten created this revision.Feb 5 2018, 9:11 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 5 2018, 9:11 AM
marten requested review of this revision.Feb 5 2018, 9:11 AM
mlaurent added inline comments.

coding style if(...) {


if (sock) {


} else {

mlaurent requested changes to this revision.Feb 5 2018, 11:49 AM
This revision now requires changes to proceed.Feb 5 2018, 11:49 AM
marten updated this revision to Diff 26580.Feb 5 2018, 2:05 PM

Diff updated for coding style, in accordance with review comments.

marten marked 3 inline comments as done.Feb 5 2018, 2:05 PM
mlaurent accepted this revision.Feb 5 2018, 9:00 PM
This revision is now accepted and ready to land.Feb 5 2018, 9:00 PM
This revision was automatically updated to reflect the committed changes.