Differential D10316

[Folder View] Let Alt+Enter open properties dialog
ClosedPublic
Actions

Authored by broulik on Feb 5 2018, 8:55 AM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:b4f3a883cf91: [Folder View] Let Alt+Enter open properties dialog
Summary

This is what Dolphin does. The shortcut is hardcoded here and also common on other platforms.

BUG: 389862
FIXED-IN: 5.13.0

Test Plan
  • Selected one file, Alt+Enter, showed properties dialog of that file
  • Selected two files, Alt+Enter, swhoed properties dialog of both files
  • Context menu still worked
  • Running file by keyboard still worked
  • Both Enter and Return were treated equally

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 5 2018, 8:55 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 5 2018, 8:55 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 5 2018, 8:55 AM
broulik edited the summary of this revision. (Show Details)
michaelh added a subscriber: michaelh.Feb 5 2018, 9:50 AM

I'm confused. On my system dolphin already behaves exactly like you described. What did I miss?
I also observed when >1 items are selected on Ctrl+Return folders open in new tabs, files open in default application. Can be mixed.
With 1 item selected there is no difference between Return and Ctrl+Return.

broulik added a comment.Feb 5 2018, 9:55 AM

This patch is about Folder View (e.g. the desktop icons), not Dolphin

michaelh added a comment.Feb 5 2018, 10:12 AM

Confusion vanished. :-)

hein accepted this revision.Feb 5 2018, 10:49 AM
This revision is now accepted and ready to land.Feb 5 2018, 10:49 AM
Closed by commit R119:b4f3a883cf91: [Folder View] Let Alt+Enter open properties dialog (authored by broulik). · Explain WhyFeb 5 2018, 12:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 26571

View Options

containments/desktop/package/contents/ui/FolderView.qml

Loading...
View Options

containments/desktop/plugins/folder/foldermodel.h

Loading...
View Options

containments/desktop/plugins/folder/foldermodel.cpp

Loading...