[x11] Fix interactive point selection
ClosedPublic
Actions

Authored by graesslin on Feb 4 2018, 5:05 PM.

Details

Reviewers

Group Reviewers

KWin
Plasma

Commits

R108:ea5e70116456: [x11] Fix interactive point selection

Summary

The support for interactive point selection was missing. This results in
the ColorPicker dbus API always returning an error on X11. We either need
to disable the ColorPicker on X11 or add support for this functionality.

As the X11 platform basically supports selecting a point in the
interactive window selection it makes more sense to add this missing
method in the platform than to disable support of color picker effect.

BUG: 387720
FIXED-IN: 5.12.1

Test Plan

Run KWin/X11 on Xephyr and was able to pick a color and
kill a window

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin created this revision.Feb 4 2018, 5:05 PM

Restricted Application added a project: KWin. · View Herald TranscriptFeb 4 2018, 5:05 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

graesslin requested review of this revision.Feb 4 2018, 5:05 PM

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptFeb 4 2018, 5:05 PM

davidedmundson accepted this revision.Feb 4 2018, 10:15 PM

This revision is now accepted and ready to land.Feb 4 2018, 10:15 PM

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptFeb 4 2018, 10:15 PM

Closed by commit R108:ea5e70116456: [x11] Fix interactive point selection (authored by graesslin). · Explain WhyFeb 5 2018, 8:22 PM

This revision was automatically updated to reflect the committed changes.

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptFeb 5 2018, 8:22 PM

Revision Contents
Changeset List

			Path	Packages
M			plugins/platforms/x11/standalone/windowselector.h (6 lines)
M			plugins/platforms/x11/standalone/windowselector.cpp (68 lines)
M			plugins/platforms/x11/standalone/x11_platform.h (1 line)
M			plugins/platforms/x11/standalone/x11_platform.cpp (8 lines)