[server] Don't crash when a subsurface gets commited whose parent surface got destroyed
ClosedPublic

Authored by graesslin on Feb 4 2018, 4:00 PM.

Details

Summary

Qt seems to damage and commit child subsurfaces although their parent
got destroyed. This actually doesn't make any sense as without a parent
surface they cannot be shown. But nevertheless we should not crash in
such a situation.

This change guards the places in the commit handling code where the
parent gets accessed.

BUG: 389231

Test Plan

New test case which exposes the problem

Diff Detail

Repository
R127 KWayland
Branch
subsurface-parent-destroyed
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin created this revision.Feb 4 2018, 4:00 PM
Restricted Application added projects: Plasma on Wayland, Frameworks. · View Herald TranscriptFeb 4 2018, 4:00 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin requested review of this revision.Feb 4 2018, 4:00 PM
Restricted Application edited projects, added Plasma; removed Plasma on Wayland. · View Herald TranscriptFeb 4 2018, 4:00 PM
davidedmundson accepted this revision.Feb 4 2018, 4:28 PM
This revision is now accepted and ready to land.Feb 4 2018, 4:28 PM
Restricted Application edited projects, added Plasma on Wayland; removed Plasma. · View Herald TranscriptFeb 4 2018, 4:28 PM

Ping? Why this has not been committed even if in "accepted" state?

Restricted Application edited projects, added Plasma; removed Plasma on Wayland. · View Herald TranscriptFeb 7 2018, 4:06 PM

Ping? Why this has not been committed even if in "accepted" state?

Because I wasn't at my system yet.

Restricted Application edited projects, added Plasma on Wayland; removed Plasma. · View Herald TranscriptFeb 7 2018, 4:26 PM
This revision was automatically updated to reflect the committed changes.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland. · View Herald TranscriptFeb 7 2018, 6:42 PM