(1/3) Remove unnecessary Discard/Quit button
ClosedPublic

Authored by ngraham on Feb 4 2018, 12:19 AM.

Details

Summary

Part 1 of 3 for T7841: Revamp buttons on the bottom to solve various usability issues

CCBUG: 386163
FIXED-IN: 18.04

Spectacle's main window doesn't need a discard/quit button, because there's already a user-visible way of closing the window: the titlebar's close button. The escape key does it, too. This button duplicates existing functionality and takes up room that could be used for a "Configure..." button, and has led to user confusion in the past as well (see https://bugs.kde.org/show_bug.cgi?id=386163)

Test Plan

Tested in KDE Neon:

  • Can still quit with the Escape key
  • Quitting automatically discards the current screenshot if it has not been saved yet
  • There's now more room in the button bar so we can add a visible "Configure..." button

Diff Detail

Repository
R166 Spectacle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham requested review of this revision.Feb 4 2018, 12:19 AM
ngraham created this revision.
ngraham edited the test plan for this revision. (Show Details)Feb 4 2018, 12:20 AM
ngraham edited the summary of this revision. (Show Details)Feb 4 2018, 12:23 AM
ngraham edited the summary of this revision. (Show Details)Feb 4 2018, 4:02 AM
ngraham edited the summary of this revision. (Show Details)Feb 4 2018, 5:38 PM
alexeymin accepted this revision.Feb 5 2018, 7:19 PM
alexeymin added a subscriber: alexeymin.

I've tested, confirming, works as described. I think removing extra buttons makes sense. Still can quit by pressing Esc :)

This revision is now accepted and ready to land.Feb 5 2018, 7:19 PM
This revision was automatically updated to reflect the committed changes.