Fix Template (Class/Function) Signatures in Clang Code Completion
ClosedPublic

Authored by shashwatdixit on Feb 3 2018, 6:58 PM.

Details

Summary
  • Create correct template prefix for Class/Function Templates
  • Handle Template Template Parameter
  • Do not drop function parameters for FunctionTemplates

BUG : 368544 , 377397

Diff Detail

Repository
R32 KDevelop
Lint
Lint Skipped
Unit
Unit Tests Skipped
shashwatdixit requested review of this revision.Feb 3 2018, 6:58 PM
shashwatdixit created this revision.
shashwatdixit edited the summary of this revision. (Show Details)
shashwatdixit edited the test plan for this revision. (Show Details)
shashwatdixit added a subscriber: kdevelop-devel.

cool stuff, some minor nitpicks otherwise lgtm! great work

plugins/clang/codecompletion/completionhelper.cpp
66 ↗(On Diff #28472)

here and below: space after if

67 ↗(On Diff #28472)

QLatin1Char(' ')

69 ↗(On Diff #28472)

move the static cast to top and then use it down here and below

auto& params = *static_cast<QStringList*>(data);
75 ↗(On Diff #28472)

dito QLatin1Char

80 ↗(On Diff #28472)

auto

This revision was not accepted when it landed; it landed in state Needs Review.Mar 15 2018, 10:44 AM
This revision was automatically updated to reflect the committed changes.