Use output names instead of screen indices
ClosedPublic
Actions

Authored by valeriymalov on Feb 3 2018, 4:59 PM.

Details

Reviewers

xuetianweng
fvogt

Commits

R530:e383b33af9d3: Use output names instead of screen indices

Summary

Screen index as an identificator can be pretty unreliable, since it can
change during the runtime (e.g. on login when kscreen applies primary
screen setting)

Use output name (e.g. HDMI-0) everywhere instead

ScreenMap: use raw ScreenSpace strings as mapping keys
ScreenSpace: introduce method next() that cycles through screen spaces
(monitors and whole desktop)
TabletAreaSelectionController: store ScreenSpace instead of index
X11Info: add helper functions to navigate through screens
TabletDaemon: remove outdated FIXME comments

Test Plan

the usual see if there aren't any regressions in saving/restoring settings
inclduing Ctrl+Meta+1/2/F/M hotkeys that cycle through screens
initially old mapping settings are going to be lost
since map0/map1/etc. aren't valid screenspaces anymore

Diff Detail

Repository

R530 Wacom tablet support

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

valeriymalov requested review of this revision.Feb 3 2018, 4:59 PM

valeriymalov created this revision.

fvogt added inline comments.Feb 3 2018, 5:22 PM

src/common/screenspace.cpp
130–138	I understand what it does, but IMO it could use an explanatory comment here.
150	Unnecessary `return`?
src/kcmodule/areaselectionwidget.cpp
252–254	You could use find here and dereference. Saves one lookup in the common case.
474	You could pass areas by const&.

Requested fixes

Looks good to me code-wise but I can't test it, I either have multiple monitors available or a graphics tablet, but not both.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 9 2018, 5:12 PM

Closed by commit R530:e383b33af9d3: Use output names instead of screen indices (authored by valeriymalov). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/kded/tablethandler/testtablethandler.cpp (3 lines)
M			src/common/screenmap.cpp (20 lines)
M			src/common/screenspace.h (21 lines)
M			src/common/screenspace.cpp (113 lines)
M			src/common/x11info.h (8 lines)
M			src/common/x11info.cpp (60 lines)
M			src/kcmodule/areaselectionwidget.h (8 lines)
M			src/kcmodule/areaselectionwidget.cpp (31 lines)
M			src/kcmodule/tabletareaselectioncontroller.h (12 lines)
M			src/kcmodule/tabletareaselectioncontroller.cpp (100 lines)
M			src/kcmodule/tabletareaselectiondialog.h (2 lines)
M			src/kcmodule/tabletareaselectiondialog.cpp (5 lines)
M			src/kcmodule/tabletareaselectionview.h (6 lines)
M			src/kcmodule/tabletareaselectionview.cpp (21 lines)
M			src/kcmodule/tabletareaselectionwidget.h (2 lines)
M			src/kcmodule/tabletareaselectionwidget.cpp (7 lines)
M			src/kded/tabletdaemon.cpp (10 lines)
M			src/kded/tablethandler.h (8 lines)
M			src/kded/tablethandler.cpp (39 lines)
M			src/kded/xinputadaptor.cpp (13 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	26447	4c1006a		Feb 3 2018, 4:59 PM	★	★
Diff 2	26552	4c1006a	- Requested fixes	Feb 5 2018, 12:20 AM	★	★
Diff 3	26829	6a85755	R530:e383b33af9d30de8e84ecf9bdd5438671b155250	Feb 9 2018, 5:12 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
0b71665baccd	cb327a2fda5d	c07205e0da2f	Valeriy Malov	Requested fixes	Feb 5 2018, 12:20 AM
c07205e0da2f	d14860e17688	4c1006af3785	Valeriy Malov	Use output names instead of screen indices (Show More…)	Feb 3 2018, 4:50 PM

Use output names instead of screen indicesClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 26829

autotests/kded/tablethandler/testtablethandler.cpp

src/common/screenmap.cpp

src/common/screenspace.h

src/common/screenspace.cpp

src/common/x11info.h

src/common/x11info.cpp

src/kcmodule/areaselectionwidget.h

src/kcmodule/areaselectionwidget.cpp

src/kcmodule/tabletareaselectioncontroller.h

src/kcmodule/tabletareaselectioncontroller.cpp

src/kcmodule/tabletareaselectiondialog.h

src/kcmodule/tabletareaselectiondialog.cpp

src/kcmodule/tabletareaselectionview.h

src/kcmodule/tabletareaselectionview.cpp

src/kcmodule/tabletareaselectionwidget.h

src/kcmodule/tabletareaselectionwidget.cpp

src/kded/tabletdaemon.cpp

src/kded/tablethandler.h

src/kded/tablethandler.cpp

src/kded/xinputadaptor.cpp

Use output names instead of screen indices
ClosedPublic
Actions

Revision Contents
Changeset List