QWebEngine
pro:
- Sticky header
- Fancy bottom border
- Ability for better redesign
cons:
- Hugh dependency
QTextBrowser
pro:
- Lightweight
cons:
- Basic design
- Even align not work in table despite docs
elvisangelaccio | |
emmanuelp | |
broulik |
Dolphin |
QWebEngine
pro:
cons:
QTextBrowser
pro:
cons:
WebEngine
TextBrowser
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Interesting. Not too fond of using Qt WebEngine, though. Can this perhaps be turned into a QTableView instead?
The main idea behind WebEngineView is that git to generate content, sticky header and only bottom border. Furthermore the code still looks simple as is.
I have also idea to draw graph at left side but i don't find any "easy way" to do it :D
I like the idea, but please fix the dependency handling
CMakeLists.txt | ||
---|---|---|
15 ↗ | (On Diff #26439) | Requiring WebEngine just for a git log plugin is too much. It should be an optional build-time dependency. |
Can you please rebase the patch? It doesn't apply currently
git/fileviewgitplugin.cpp | ||
---|---|---|
421 | QLatin1Starting here (because startsWith() has an overload for it). | |
433–435 | Why not using the new C++11 syntax: QStringList {QStringLiteral("foo"), QStringLiteral("bar"), ...} | |
458 | Hmm this should probably not be translated. If you are using git, you know what "git log" means ;) |
Is it normal that the dolphin process does not quit if I close the dolphin window but not the Git Log window?
git/fileviewgitplugin.cpp | ||
---|---|---|
421 | Actually, maybe we can just check if the scheme() of the url is "rev". |
git/fileviewgitplugin.cpp | ||
---|---|---|
420 | QLatin1String here (faster with != operator) |